D15177: Emit signals when a package is installed/uninstalled

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Sep 10 10:56:04 BST 2018


broulik added inline comments.

INLINE COMMENTS

> packagejob.cpp:90
> +        if (ok) {
> +            const QString pluginId = d->package->metadata().pluginId();
> +            const QStringList serviceTypes = d->package->metadata().serviceTypes();

Can this be invalid or does `install` already check for validity?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180910/1dde7b5f/attachment.html>


More information about the Kde-frameworks-devel mailing list