D13700: implement reading of the replaygain tags

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Sep 8 03:08:54 BST 2018


bruns added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:943
> +            }
> +            result->add(Property::ReplayGainAlbumGain, data.replayGainAlbumGain.toDouble());
> +        }

You should check if the value can be converted to double, and probably also if it is in a sane range.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180908/9604fe25/attachment.html>


More information about the Kde-frameworks-devel mailing list