D15328: kfilewidget: convert connect syntax

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Sep 7 18:00:01 BST 2018


bruns added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfilewidget.cpp:1225
>   QObject::disconnect(m_connEditTextChanged);
>   m_connEditTextChanged = QMetaObject::Connection();

Me neither ...

But me wonders if this should not use `{QSignalBlocker(locationEdit); ...}` instead.
Also, the comment above is slightly wrong, there is no `setCurrentItem()` below.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15328

To: jtamate, dfaure, #frameworks
Cc: bruns, anthonyfieroni, broulik, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180907/91e916e1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list