D15072: [server] Abort drag start on correct conditions and without posting error
Adriaan de Groot
noreply at phabricator.kde.org
Tue Sep 4 14:30:12 BST 2018
adridg added inline comments.
INLINE COMMENTS
> datadevice_interface.cpp:103
> // TODO: allow touch
> - if (seat->hasImplicitPointerGrab(serial) && seat->focusedPointerSurface() != origin) {
> - wl_resource_post_error(resource, 0, "Surface doesn't have pointer grab");
> + if (!seat->hasImplicitPointerGrab(serial) || seat->focusedPointerSurface() != origin) {
> + // Surface doesn't have pointer grab.
this looks like it's still missing a !, based on the explanation "when the client does not have an implicit pointer grab"
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15072
To: romangg, #kwin
Cc: adridg, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180904/363f047f/attachment.html>
More information about the Kde-frameworks-devel
mailing list