D15180: kioexecd: watch for creations or modifications of the temporary files

Anthony Fieroni noreply at phabricator.kde.org
Tue Sep 4 08:05:19 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> kioexecd.cpp:53
>      connect(m_watcher, &KDirWatch::deleted, this, &KIOExecd::slotDeleted);
> +    m_timer.setSingleShot(true);
> +    connect(&m_timer, &QTimer::timeout, this, &KIOExecd::slotCheckDeletedFiles);

Also add interval here, setInterval, in other place just start()

> kioexecd.cpp:85-88
> +    if (!m_deleted.contains(path)) {
> +        m_deleted_mutex.unlock();
> +        return;
> +    }

Now it's not needed 'remove' will do the work

> kioexecd.cpp:143
> +            QDir(parentDir).removeRecursively();
> +            it=m_deleted.erase(it);
> +        } else {

lvalue = rvalue (i mean space between =)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180904/1607a8b8/attachment.html>


More information about the Kde-frameworks-devel mailing list