D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Sep 3 14:48:47 BST 2018
broulik created this revision.
broulik added reviewers: dfaure, elvisangelaccio, fvogt, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Avoids creating a `QFileInfo` which might block `stat`'ing the file, especially if the information has been filled in by a KIO slave already.
TEST PLAN
- Unittest still passes
- Had an own file that I removed the own permission → became unreadable
- Had a file from someone else but in the same group as me → was readable
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15242
AFFECTED FILES
src/core/kfileitem.cpp
To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180903/8af2292a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list