D13700: implement reading of the replaygain tags

Alexander Stippich noreply at phabricator.kde.org
Sun Sep 2 12:27:34 BST 2018


astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:255
> you can use TStringToQString
> `data.replayGainTrackGain = TStringToQString(userTextFrame->fieldList().back());`

toCString() was actually completely unnecessary. I removed it since convertWChartsToQString() avoids the UTF16->UTF8->UTF16 conversion of TStringToQString

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180902/b5b4f1bd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list