D16529: make libssh module default to the "new" libssh config by default

[Harald Sitter]

sitter created this revision.
sitter added reviewers: broulik, asn.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - rename module from LibSSH to libssh so casing is consistent with config
  - module now quietly attempts to find libssh by config and returns if found
  - if it was not found we'll fall back to manual lookup
  - adjust actual FOUND variable use for correct case
  - fix package case in properties set up (this is case sensitive)
  
  this is singularly necessary because the config file is not correctly
  packaged in ubuntu 18.04 (LTS)
  
  https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135/comments/2
  
  This reverts 3b1fd6bd8866da2dadd33705af53613236503efc <https://phabricator.kde.org/R320:3b1fd6bd8866da2dadd33705af53613236503efc>.
  
  BUG: 400291

TEST PLAN
  builds in ubuntu docker container and with a system that has a proper config

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16529

AFFECTED FILES
  CMakeLists.txt
  cmake/Findlibssh.cmake

To: sitter, broulik, asn
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181030/fd82c24d/attachment.html>