D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Igor Poboiko]

poboiko added a comment.


  That's nice! I'll test it a little.

INLINE COMMENTS

> app.cpp:74
> +
> +    memcpy(&nIds, buf, 4);
> +    for (quint32 i = 0; i < nIds; i++) {

I haven't work with `QDataStream` before, but shouldn't `m_inputStream >> nIds` do the same? (and same below)
And probably you should avoid magical constants (4, 8, etc) - better use corresponding `sizeof`s

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181030/d3abfb5f/attachment-0001.html>