D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The handler does not handle partial reads, and most importantly, does
  not handle when the pipe from the parent process is closed.
  
  Although this should not happen during normal operation, in case of a
  crash the indexer process will receive QSocketNotifier::activated events
  due to 'POLLHUP' events from the underlying poll. This causes a busy
  loop, as the underlying pipe status is never checked.
  
  May fix a few instances of "100% CPU load" bug reports.

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16523

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/CMakeLists.txt
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181030/8bfe77bf/attachment.html>