D16522: [Extractor] Do not check QFile::exists for an empty url
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Tue Oct 30 02:22:02 GMT 2018
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, dfaure, apol.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
In case the file has been removed from the IdTree DB, but is still in the
IndexingLevelDB, documentUrl(id) may return an empty name. Skip the
check if the name isEmpty().
Qt 5.10 issues a runtime warning otherwise - 'Empty filename passed to
function'.
See also D8697 <https://phabricator.kde.org/D8697>.
REPOSITORY
R293 Baloo
BRANCH
extractor
REVISION DETAIL
https://phabricator.kde.org/D16522
AFFECTED FILES
src/file/extractor/app.cpp
To: bruns, #baloo, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181030/b1bcf7be/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list