D16490: [KFileMetaData] Add unittest for XML extractor
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Mon Oct 29 09:40:59 GMT 2018
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> lbeltrame wrote in xmlextractortest.cpp:38
> IIRC you shouldn't use `QDir::separator()`. See http://agateau.com/2015/qdir-separator-considered-harmful/
Thx, fixed here and elsewhere (D16505 <https://phabricator.kde.org/D16505>)
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16490
To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181029/2ed7e6d8/attachment.html>
More information about the Kde-frameworks-devel
mailing list