D16466: [KSambaShare] Add unit test for "net usershare list" parser

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Oct 27 18:45:18 BST 2018


bruns created this revision.
bruns added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The existing tests depend on the runtime environment, i.e. they read
  the share list from the developers usershares. In case the account
  has no usershares, the parser is not tested.
  
  Inject some test data for several test cases into the parser.
  
  As the KSambaSharePrivate::parse() method is not visible from the
  shared library by default, link statically to it.
  
  Depends on D16464 <https://phabricator.kde.org/D16464>
  Depends on D16465 <https://phabricator.kde.org/D16465>

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16466

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksambashareprivatetest.cpp
  autotests/ksambashareprivatetest.h

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181027/b2edb904/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list