D16465: [KSambaShare] Make "net usershare list" parser testable

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Oct 27 18:44:16 BST 2018


bruns created this revision.
bruns added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  KSambaSharePrivate::sync() reads from the runtime environment of the user
  and modifies the the share list in place.
  
  Split out the parser part, and create a fresh share list from the input,
  which replaces the old list after parsing.

TEST PLAN
  make && ctest
  no functional changes

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16465

AFFECTED FILES
  src/core/ksambashare.cpp
  src/core/ksambashare_p.h

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181027/b200b9f3/attachment.html>


More information about the Kde-frameworks-devel mailing list