D16434: Fix keyboard layout change notifications
Fabian Vogt
noreply at phabricator.kde.org
Fri Oct 26 09:04:36 BST 2018
fvogt created this revision.
fvogt added reviewers: Frameworks, Plasma.
Herald added a project: Frameworks.
fvogt requested review of this revision.
REVISION SUMMARY
This rework fixes several issues:
- Qt wasn't informed about XCB_MAPPING_NOTIFY anymore
- With XKB enabled in Qt, X won't send XCB_MAPPING_NOTIFY anymore. So listen for XKB events as well.
- Install the event filter before fetching the keysym mapping to close a race window
- Use the old mapping for ungrabbing
BUG: 350816
BUG: 269403
TEST PLAN
Ctrl-Alt-Y global shortcut works even when doing
"setxkbmap us; kglobalaccel5 & sleep 1; setxkbmap de;" while it did not
before. On some systems, this race happened on every login, now it works
reliably.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16434
AFFECTED FILES
CMakeLists.txt
src/runtime/plugins/CMakeLists.txt
src/runtime/plugins/xcb/CMakeLists.txt
src/runtime/plugins/xcb/kglobalaccel_x11.cpp
src/runtime/plugins/xcb/kglobalaccel_x11.h
To: fvogt, #frameworks, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181026/6ad1c35a/attachment.html>
More information about the Kde-frameworks-devel
mailing list