D16416: z/OS CLIST file syntax highlighting

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed.

INLINE COMMENTS

> clist.xml:3
> +<!DOCTYPE language SYSTEM "language.dtd">
> +<language name="CLIST" version="2" kateversion="2.2" section="Scripts" extensions="*.clist;*.CLIST" mimetype="">
> +  <highlighting>

license="MIT" is missing.

> clist.xml:3
> +<!DOCTYPE language SYSTEM "language.dtd">
> +<language name="CLIST" version="2" kateversion="2.2" section="Scripts" extensions="*.clist;*.CLIST" mimetype="">
> +  <highlighting>

kateversion="5.0", or are you indeed using an old Kate before Plasma5?

> clist.xml:61
> +      </context>
> +      <context attribute="Comment" lineEndContext="#stay" name="Commentar 1">
> +        <RegExpr attribute="Alert" context="#stay" String="(FIXME|TODO)" />

Maybe rename Commentar 1 to simply Comment? It seems you copy & pasted the file :)

> clist.xml:62
> +      <context attribute="Comment" lineEndContext="#stay" name="Commentar 1">
> +        <RegExpr attribute="Alert" context="#stay" String="(FIXME|TODO)" />
> +        <Detect2Chars attribute="Comment" context="#pop" char="*" char1="/" endRegion="Comment"/>

Please use IncludeRules with ##Alerts, look into other highlighting files how this is done.

> clist.xml:69
> +      <itemData name="Comment"      defStyleNum="dsComment"/>
> +      <itemData name="Control"      defStyleNum="dsNormal" color="#000090"/>
> +      <itemData name="Assignment"   defStyleNum="dsBuiltIn"/>

Please remove the hard coded color. Hard coded colors are an issue with different color schemes. See https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ for more default styles.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16416

To: phily, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181026/aa57a922/attachment-0001.html>