D16421: Improve emblem contrast, legibility and consistency

Noah Davis noreply at phabricator.kde.org
Fri Oct 26 01:03:41 BST 2018


ndavis added a comment.


  In D16421#348609 <https://phabricator.kde.org/D16421#348609>, @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that explicitly or implicitly trims the bounds of loaded images that could account for the link emblem not having its original bounds respected and results in it being drawn too high. Either I missed the part that does this (which is quite possible), or it's some implicit thing in the SVG image itself (which is also possible, since I know nothing about SVG images), or it's something else entirely.
  
  
  It's not that the symlink emblem gets trimmed, it's just normally off. In this image, I changed the background of the symlink emblem to take up the whole canvas and it's 2 pixels farther in than the vcs-normal emblem.F6356652: Screenshot_20181025_195954.png <https://phabricator.kde.org/F6356652>

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181026/b6b79466/attachment.html>


More information about the Kde-frameworks-devel mailing list