D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this seems to work well.

INLINE COMMENTS

> app.cpp:133
> +    if (!m_config.shouldBeIndexed(url)) {
>          // FIXME: This should never be happening!
> +        qCWarning(BALOO) << "Found" << url << "in the ContentIndexingDB, although it should be skipped";

Is this FIXME still in need of fixing with your changes here?

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16236

To: bruns, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181025/8c9a8ded/attachment.html>