D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348361 <https://phabricator.kde.org/D16421#348361>, @ndavis wrote:
  
  > I agree with you, but I also don't like the look of orange. It's just not a color that I would expect. I would be OK with making `emblem-added` and `emblem-remove` grey like the reporter (Tyson Tan) from bug#399968 asked for, but I don't know if that would work well for programs besides Dolphin.
  >  Here's what orange would look like:
  >  F6349094: Screenshot_20181024_215403.png <https://phabricator.kde.org/F6349094>
  
  
  Yeah I understand. I'm not the hugest fan of the orange either, and now that I think about it, semantically it's not really accurate either since that color is for warning or unusual states. Maybe it should just be blue like `emblem-added` is?
  
  In D16421#348361 <https://phabricator.kde.org/D16421#348361>, @ndavis wrote:
  
  > > Another thing is the `emblem-symbolic-link` icon. It's the only common-ish one that doesn't follow the pattern of having a colored background with a border, which might muddy the design language you've chosen (which I love).
  >
  > You're right, but I also like how the chain link looks. How is this? F6349126: Screenshot_20181024_222138.png <https://phabricator.kde.org/F6349126>
  
  
  With that, it doesn't look so much like a chain link anymore because the two sides of it are so close together. Could we basically use the existing chain link shape but put it within a background? Maybe it doesn't even need to be square; it could be rectangular, or even pill-shaped.
  
  >> Since this fixes all three bugs, you can replace
  >> 
  >>   https://bugs.kde.org/show_bug.cgi?id=399356
  >>   https://bugs.kde.org/show_bug.cgi?id=399357
  >>   https://bugs.kde.org/show_bug.cgi?id=399968
  >> 
  >> 
  >> with
  >> 
  >>   BUG: 399356
  >>   BUG: 399357
  >>   BUG: 399968
  >>   FIXED-IN: 5.52
  > 
  > You mean I should change the summary to say that?
  
  Exactly!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181025/58424654/attachment-0001.html>