D16265: [Scheduler] Use flag to track when a runner is going idle

Igor Poboiko noreply at phabricator.kde.org
Sat Oct 20 14:07:21 BST 2018


poboiko added a comment.


  I like it, it's better than D15959: Wait for the extraction process to finish before scheduling <https://phabricator.kde.org/D15959>. 
  And it seems to be working, as far as I can see :)

INLINE COMMENTS

> fileindexscheduler.h:57
>              m_newFiles << file;
> -            QTimer::singleShot(0, this, &FileIndexScheduler::scheduleIndexing);
> +            if (m_indexerState == Idle || m_isGoingIdle) {
> +                QTimer::singleShot(0, this, &FileIndexScheduler::scheduleIndexing);

But the very same check is already in the first line of `scheduleIndexing`, why do we need it also here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16265

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181020/be4e216b/attachment.html>


More information about the Kde-frameworks-devel mailing list