D16311: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Oct 19 11:54:20 BST 2018
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
This ensure hovering a broken mount will not freeze the UI.
I already optimized it in D11088 <https://phabricator.kde.org/D11088> to avoid doing blocking calls for when the bar isn't shown but this patch makes it fully async now.
Moreover, refresh only every 60 seconds (it's what Dolphin as well as Plasma's free space warning do), currently it would refresh every frame
TEST PLAN
Capacity bar shows up for a mounted drive and updates after a while when you hover it again.
It doesn't update "live" but it never did that, only happened to because it was querying free space like a mad man.
In theory this would also enable free space bars for network shares but `CapacityBarRecommendedRole` is only for mounted local storage sans CD rom.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16311
AFFECTED FILES
src/filewidgets/kfileplacesview.cpp
To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181019/344a4976/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list