D16283: implement more tags for asf metadata

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:739
> this makes me always wonder why we don't do:
> 
>   // decltype(data.albumArtists) == QStringList
>   for (attribute : lstAsf) {
>     QString t = TStringToQString(attribute.toString());
>     data.albumArtists << contactsFromString(t);
>   }

Yeah, there is a lot of unneccesary stuff in there that must be cleaned up. But before I get to that, I would like to add tests for multiple entries, and before that we have to agree how the output of mutliple entries shall look like, which brings me to D12950 <https://phabricator.kde.org/D12950> :)

> bruns wrote in taglibextractor.h:28
> Side note - I think `tfilestream.h` is no longer needed.

Is it okay if I push this directly?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16283

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181018/266134c0/attachment.html>