D16266: [Extractor] Make extractor crash resilient

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 17 11:08:36 BST 2018


broulik added inline comments.

INLINE COMMENTS

> poboiko wrote in filecontentindexer.cpp:75
> Is it OK to use `QObject::connect` inside a `while` loop? Those are not `Qt::UniqueConnection`, won't they fire multiple times (more and more, actually)?

given `loop` lives on the stack it is destroyed when the scope is left and the connection severed

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181017/1d670cb7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list