D16266: [Extractor] Make extractor crash resilient

[Stefan Brüns]

bruns marked 3 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> apol wrote in extractorprocess.cpp:35
> Shouldn't it check the exitCode too?

the exitCode is "only valid for normal exits" (Qt docu <http://doc.qt.io/qt-5/qprocess.html#exitStatus>), and 0 otherwise.

> apol wrote in extractorprocess.cpp:54
> Do you really need to waitForStarted?

Copied from the old code. Should not hurt, as done from a runner thread.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16266

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181016/7aa850b8/attachment.html>