D16266: [Extractor] Make extractor crash resilient
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Tue Oct 16 23:47:59 BST 2018
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Connect to QProcess::finished to detect the exit status. In case the
process has crashed, signal the indexer.
On a crash, restart the process and feed it a smaller batch. If the
crashing batch contains only a single file, mark the file as failed, i.e.
add it to the "failedid" db and remove it from the content indexing db
to avoid further indexing attempts.
CCBUG: 375131
TEST PLAN
start `balooctl monitor`
add a file known to crash the extractor to an indexable path
touch an unproblematic file
-> indexer crashes on first file and continues with the second
REPOSITORY
R293 Baloo
BRANCH
mimetype_handling
REVISION DETAIL
https://phabricator.kde.org/D16266
AFFECTED FILES
src/file/extractorprocess.cpp
src/file/extractorprocess.h
src/file/filecontentindexer.cpp
src/file/filecontentindexerprovider.cpp
src/file/filecontentindexerprovider.h
To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181016/ce0a9cdd/attachment.html>
More information about the Kde-frameworks-devel
mailing list