D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The BasicIndexingJob started from the UnindexedFileIndexer only has
  the file extension based mimetype and thus can not determine if a file
  should be indexed.
  
  Remove the document only from the indexingleveldb, otherwise the
  document can not be found e.g. by name or type, and the basic indexer is
  run on the file again on each session start.
  
  This is typical for e.g. xml files, which may come with various file
  extensions based on the application, e.g. XMP sidecar files.

TEST PLAN
  start `balooctl monitor`
  save some metadata to an XMP sidecar file, e.g. from digikam
  -> the file is added to the index and immediately removed again.
  When content indexing is switched off, the file stays in the
  index.
  
  After the change, the file stays in the index.

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16236

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181016/c17ca082/attachment.html>