D16137: Add an option to KConfigDialog to fit page contents horizontally
Tim __
noreply at phabricator.kde.org
Sun Oct 14 18:56:38 BST 2018
kadabash added a comment.
In D16137#342973 <https://phabricator.kde.org/D16137#342973>, @aacid wrote:
> That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.
>
> Am I making sense?
Did you imagine something like what I changed in D16137#343060 <https://phabricator.kde.org/D16137#343060> (the latest change) ?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D16137
To: kadabash
Cc: ngraham, svuorela, aacid, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181014/035321cb/attachment.html>
More information about the Kde-frameworks-devel
mailing list