D16163: refactor taglibextractor to functions specific for metadata type
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Fri Oct 12 18:59:01 BST 2018
bruns added inline comments.
INLINE COMMENTS
> taglibextractor.h:31
> +#include <xiphcomment.h>
> #include <tfilestream.h>
>
Keep the includes in the implementation and just do a forward declaration of the types (possible as you only use these as pointer types in the header).
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16163
To: astippich, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181012/53f33766/attachment.html>
More information about the Kde-frameworks-devel
mailing list