D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

Igor Poboiko noreply at phabricator.kde.org
Fri Oct 12 08:55:21 BST 2018


poboiko added a comment.


  I'm not entirely sure how translating system works, but won't it pop up as 4 identical lines in i.e. `Lokalize`, causing frustration to our translators? 
  It would also mean that if we would want to change the message, we would have to do it in 4 different lines.
  
  I suggest introducing something like an `QString errorMessage` and printing it only once.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15826

To: bruns, #baloo, #frameworks, poboiko
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181012/70de225d/attachment.html>


More information about the Kde-frameworks-devel mailing list