D16137: Add an option to KConfigDialog to fit page contents horizontally
Tim __
noreply at phabricator.kde.org
Thu Oct 11 18:55:25 BST 2018
kadabash created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kadabash requested review of this revision.
REVISION SUMMARY
Scrolling a settings page horizontally feels awkward most of the time.
This (optionally) lets the dialogue resize when it is opened so that
horizonal scrolling becomes unnecessary.
Things I am uncertain about:
- Placement of the "FittingScrollArea" class above the function where it is used, and its name.
- "fitContentHorizontally" is off by default in "KConfigDialog::addPage()" so existing code using the function not break because of this change.
This change was discussed in Phabricator Differential D16048 <https://phabricator.kde.org/D16048>.
REPOSITORY
R265 KConfigWidgets
BRANCH
config-dialog-content-fit (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D16137
AFFECTED FILES
src/kconfigdialog.cpp
src/kconfigdialog.h
To: kadabash
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181011/767668d9/attachment.html>
More information about the Kde-frameworks-devel
mailing list