D16060: Reduce double and triple lookups to the frames hash

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 10 15:44:37 BST 2018


broulik added inline comments.

INLINE COMMENTS

> framesvg.cpp:967
>  {
> -    references[svg] = references[svg] - 1;
> -    //qCDebug(LOG_PLASMA) << this << svg << references[svg];
> -    if (references[svg] < 1) {
> -        references.remove(svg);
> +    auto it = references.find(svg);
> +    (*it)--;

Can we assume `references` always contains `svg`?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16060

To: apol, #plasma, davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181010/9b2e990a/attachment.html>


More information about the Kde-frameworks-devel mailing list