D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Thanks for the explanation. Looks good then, just update the summary.
  
  You could add another column to the tests, "hasFullImplementation", and do an Q_EXPECT_FAIL if not set. But thats for another patch ...

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_taglib_extractor_tests

REVISION DETAIL
  https://phabricator.kde.org/D15825

To: astippich, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181009/d950600c/attachment.html>