D16049: Added missing Icons to Places Panel code from KIO

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This doesn't apply cleanly:
  
    Checking patch src/filewidgets/kfileplacesview.cpp...
    Hunk #1 succeeded at 745 (offset 3 lines).
    error: while searching for:
                add = menu.addAction(QIcon::fromTheme(QStringLiteral("document-new")), i18n("Add Entry..."));
            }
    
            hide = menu.addAction(i18n("&Hide Entry '%1'", label));
            hide->setCheckable(true);
            hide->setChecked(placesModel->isHidden(index));
            // if a parent is hidden no interaction should be possible with children, show it first to do so
    
    error: patch failed: src/filewidgets/kfileplacesview.cpp:778
    Hunk #3 succeeded at 802 (offset 12 lines).
    Applying patch src/filewidgets/kfileplacesview.cpp with 1 reject...
    Hunk #1 applied cleanly.
    Rejected hunk #2.
    Hunk #3 applied cleanly.
    
     Patch Failed! 
    Usage Exception: Unable to apply patch!
  
  Can you rebase the patch on master?
  
  Also, you might want to set up `arc`, which makes it much simpler and faster to submit patches, and easier for me too. https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16049

To: alexde, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181009/31fd490a/attachment.html>