D15973: Add a 'Propreties' entry in the places panel context menu

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodel.cpp:957
>  
> +void KFilePlacesModel::requestProperties(const QModelIndex &index, QWidget *parent)
> +{

Why is this in the model, rather than being in the view?
It shows a dialog, that sounds more like something for the view.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181007/1edecedc/attachment-0001.html>