D15829: make units and prefixes of formatValue translatable

Safa Alfulaij noreply at phabricator.kde.org
Sun Oct 7 14:40:47 BST 2018


safaalfulaij accepted this revision.
safaalfulaij added a comment.
This revision is now accepted and ready to land.


  Thanks!
  I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the dot or remove it in the `unitString`s translation. (`"bit"` -> `".bit"`, `"m"` -> `"m"`)
  By the way, shouldn't that also be the case for English? I don't see people write `"1 m"` but `"1m"`, `"200 B"` but `"200B"`, same for `Hz`, not sure about `bit`s. The space is not there when abbreviation is used.

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181007/38425e9b/attachment.html>


More information about the Kde-frameworks-devel mailing list