D15943: [balooctl] Monitor also for state changes

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Oct 6 11:26:34 BST 2018


bruns added a comment.


  In D15943#337522 <https://phabricator.kde.org/D15943#337522>, @poboiko wrote:
  
  > In D15943#337385 <https://phabricator.kde.org/D15943#337385>, @ngraham wrote:
  >
  > > Works for me and the code looks sane. Looks like this fixes https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and `FIXED-IN: 5.52` to the summary section and also make the changes that @bruns requested? Thanks!
  >
  >
  > Weird, bug 364858 should be fine as it is - user asks for a way to display files Baloo is currently processing, but that's exactly what `monitor` does (even without this patch).
  
  
  I think 364858 is not affected by this, but is still broken.
  
  The monitor command watches for **changes** of the filename, but misses to fetch `currentFile` on startup. When the indexer "hangs", we never get a signal.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181006/c609e7d0/attachment.html>


More information about the Kde-frameworks-devel mailing list