D15939: Perform checks for unindexed files and stale index entries on startup
Igor Poboiko
noreply at phabricator.kde.org
Thu Oct 4 13:14:10 BST 2018
poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks, vhanda.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
Right now, if a file was moved / removed while baloo_file was not running
(a common use-case for those who have dualboot), there is no way baloo will
become aware of such change (apart from running `balooctl check` by hand).
There will be stale (if a file was removed) or invalid (pointing to non-existing file,
if a file was moved) index entries, they will pop up if user performs search, which is
frustrating. I suggest performing those checks on `baloo_file` startup.
TEST PLAN
1. `balooctl stop && echo "hello world" > ~/new-file && balooctl start`
2. after some time: `balooshow ~/new-file`, and see if it's indexed
REPOSITORY
R293 Baloo
BRANCH
startup-checks (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15939
AFFECTED FILES
src/file/fileindexscheduler.cpp
src/file/fileindexscheduler.h
src/file/indexerstate.h
src/file/mainhub.cpp
To: poboiko, #baloo, #frameworks, vhanda
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181004/289a45d4/attachment.html>
More information about the Kde-frameworks-devel
mailing list