D15935: Don't show a emblem for mounted disks, only unmounted disks

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  #VDG <https://phabricator.kde.org/tag/vdg/> is finalizing a guideline for the use of emblems stating that they should only be used for non-default, uncommon, unusual, or unexpected  statuses. This is described in D15897 <https://phabricator.kde.org/D15897>.
  
  Accordingly, we should only show an emblem when a disk is unmounted, not when it's mounted. Being mounted is the expected status for a disk; being unmounted-but-visible-anyway is what's unusual and deserves an emblem.
  
  As an added bonus, this hugely improves the look of the Places panel by default.
  
  Closes T9740 <https://phabricator.kde.org/T9740>

TEST PLAN
  Dolphin Places panel now:
  [image goes here]

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181004/f7de7227/attachment.html>