D15931: [Places panel] use more appropriate network icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The current Breeze icon used for the default Network(`network-workgroup`) is not ideal for several reasons:
  
  - It it not clear what it depicts (I was told it's a server rack, but there's not enough detail to make this apparent)
  - Even if the visuals were clear, its iconography (a server rack) is not familiar to people who are not sysadmins
  
  This patch replaces it with `folder-network`, which yields the following improvements:
  
  - This icon includes the "sideways dotted V" imagery that is used in other contexts (shared folder emblem, Share menu, which teaches the user its meaning
  - Many other platforms use circular globe or world iconography for their network icons. Even though this new icon is not a globe or world, it is circular, which helps to re-use some of a user's prior experience on other platforms
  - Semantically, `folder-network` is just a more appropriate icon to use for this than `network-workgroup`. The item leads to the whole network, not a specific workgroup.

TEST PLAN
  New icon shows up in all Places panels for new user accounts, or if you delete `~/.local/share/user-places.xbel` in an existing user account
  
  Dolphin Places panel:
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181003/bcf3b262/attachment-0001.html>