D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

Christoph Feck noreply at phabricator.kde.org
Tue Oct 2 13:14:01 BST 2018


cfeck added inline comments.

INLINE COMMENTS

> jtamate wrote in rgb.cpp:702
> Shouldn't it be QLatin1String("\x01\xda\x01")?
> startsWith has a QLatin1String overloaded method, but will it be used if a char* is used as argument or will it use the QString method? I just don't know the answer.
> Otherwise, +1.

`head` is a QByteArray, not a QString.

REPOSITORY
  R287 KImageFormats

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15890

To: dfaure, cfeck
Cc: jtamate, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181002/8e7b4097/attachment.html>


More information about the Kde-frameworks-devel mailing list