D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

[Christoph Feck]

cfeck accepted this revision.
cfeck added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> rgb.cpp:702
>  
> -    const QRegExp regexp(QLatin1String("^\x01\xda\x01[\x01\x02]"));
> -    QString data(QString::fromLocal8Bit(head));
> -
> -    return data.contains(regexp);
> +    return head.size() >= 4 && head.startsWith("\x01\xda\x01") && (head[3] == 1 || head[3] == 2);
>  }

head[i] → head.at(i)

REPOSITORY
  R287 KImageFormats

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15890

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181002/df9529a1/attachment-0001.html>