D17210: Added proxy and user settings

Pranav Gade noreply at phabricator.kde.org
Thu Nov 29 14:38:02 GMT 2018


pranavgade marked 3 inline comments as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in proxysetting.cpp:25
> It looks that the proxy setting has been introduced in NetworkManager 1.6. This means that for all property defines, you have to add ifdef the same way you did for ip tunnel setting.

Fixed according to:
https://developer.gnome.org/libnm/stable/NMSettingProxy.html#NM-SETTING-PROXY-METHOD:CAPS

REVISION DETAIL
  https://phabricator.kde.org/D17210

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181129/507eaf03/attachment.html>


More information about the Kde-frameworks-devel mailing list