D17210: Added proxy and user settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> iptunnelsetting.cpp:35
>      , encapsulationLimit(0)
> -    , flags(IpTunnelSetting::Unknown)
> +    , flags(IpTunnelSetting::None)
>      , flowLabel(0)

This is an unrelated change, submit it in a different review, but thanks for spotting this.

> proxysetting.cpp:26
>  
> +#if NM_CHECK_VERSION(1, 16, 0)
> +#define NM_SETTING_PROXY_SETTING_NAME    "proxy"

I said NM 1.6, not 1.16 and you need !NM_CHECK_VERSION(1, 6, 0).

> proxysetting.h:42
>      typedef QList<Ptr> List;
> +    enum Mode
> +    {

Coding style. It should be:

enum Mode {
....
}

> usersetting.cpp:26
>  
> +#if NM_CHECK_VERSION(1, 8, 0)
> +#define NM_SETTING_USER_SETTING_NAME    "user"

Same here. It should be !NM_CHECK_VERSION(1, 8, 0).

REVISION DETAIL
  https://phabricator.kde.org/D17210

To: pranavgade, jgrulich
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181129/12800e72/attachment-0001.html>