D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

INLINE COMMENTS

> CMakeLists.txt:175
> +   add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to build the NFS kioslave")
> +   if(RPC_H_DIR)
>       add_subdirectory( nfs )

I would prefer a real build option instead of automagic here, and the detection below that conditional. I'm aware that's more than what we have right now.

> cgiboudeaux wrote in CMakeLists.txt:4
> This won't work for openSUSE:  the tirpc headers are installed in /usr/include directly.

Could you suggest an alternative? Gentoo shares a similarity with Arch there, because otherwise libtirpc could collide with older versions of glibc.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181127/aac09ac0/attachment.html>