D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

Luca Beltrame noreply at phabricator.kde.org
Thu Nov 22 06:38:38 GMT 2018


lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  LGTM; just a minor change needed.

INLINE COMMENTS

> basicindexingjob.cpp:153
> +        //{"application/vnd.ms-excel", Type::Document},
> +        //{"application/vnd.ms-excel", Type::Spreadsheet},
>          // Office 2007

Remove instead of committing commented out code?

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17089

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181122/39611c39/attachment.html>


More information about the Kde-frameworks-devel mailing list