D17070: Don't double-count size of directories in DirectorySizeJob
David Edmundson
noreply at phabricator.kde.org
Wed Nov 21 12:18:11 GMT 2018
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Running "stat" on a directory gives a size of on ext3 gives a size of
"4096".
DirectorySizeJob has a bug that it counts this directory size twice.
Once when it encounters a directory in the entry list, then again when
it finds the "." entry in that subdirectory.
The unit test passes because it's super vague to be file system
independent.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17070
AFFECTED FILES
src/core/directorysizejob.cpp
To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181121/31ff448d/attachment.html>
More information about the Kde-frameworks-devel
mailing list