D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> copyjob.cpp:1602
>      QList<CopyInfo>::Iterator it = files.begin();
> +    const auto fileSystem = KFileSystemType::fileSystemType(m_globalDest.toString());
>      // Is this URL on the skip list ?

This is going to slow down copying in the normal case. This check should only be done if the size is too big (i.e. inside the `if` further down).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181121/d23346c8/attachment.html>