D17015: Fix the Qt doc creation with Qt 5.12.

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)
  
  Any idea how we could perhaps deduplicate the  FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated variants for each purppse? Needs me another round of thinking.

INLINE COMMENTS

> ECMQueryQmake.cmake:6
> +else()
> +    find_program(_qmake_executable_default NAMES qmake-qt5)
>  endif()

Perhaps worth to add a comment describing all known scenarios why we reach the else branch.
The version with find_package(Qt5Core) failing due to NONE language would be not on my radar, thus nice to have it listed here for future code readers.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181120/0b5c670a/attachment.html>