D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli marked an inline comment as done.
lsartorelli added inline comments.

INLINE COMMENTS

> aacid wrote in ktoggleshowmenubaraction.cpp:77
> If shortcut() returns a QKeySequence (i think it does), you want toString(NativeText)
> 
> Not a native speaker but i don't think "typing" is what you want, i'd say "pressing".
> 
> Also what if there's no shortcut?

Do you suggest to add a warning in case of no shortcut?
The only options I am thinking of are
to tell the user add the missing shortcut via system settings,
to tell the user to modify the config file for current app or
I don't know

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181120/b5af866d/attachment.html>