firewall-applet icons break breeze auto tests

Noah Davis noahadvs at gmail.com
Mon Nov 19 19:02:37 GMT 2018


On Monday, November 19, 2018 6:53:28 AM EST Harald Sitter wrote:
> I am CCing Andreas Kainz on this as he may have input on where the
> firewall-* icons should go.
> From a quick look though I am convinced the majority/all of these
> icons should be in status/ not apps/. They are used in the system tray
> from what I understand, not actual application icons. apps/ is
> basically only for icons that would show up in the applications menu.
> 
> (the scalable test that is failing also does not apply to status/, so
> by moving the icons to the correct directory you'd fix the test)
> 
> HS

I put the icons into apps/ because the applet's hicolor icons are also placed 
into apps, but you may be right that status/ would be a better location. I did 
not know that apps/ was for icons that show up in the application menu, but 
that makes sense.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181119/9bb00aec/attachment.sig>


More information about the Kde-frameworks-devel mailing list